Skip to content

Compare commit performance #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roversch merged 5 commits into from
Aug 13, 2024
Merged

Compare commit performance #20

roversch merged 5 commits into from
Aug 13, 2024

Conversation

@roversch
Copy link
Collaborator

@roversch roversch commented Aug 6, 2024

This pull request adds functionality to keep track of performance across commits.

  • one folder is added for each commit (name is short SHA)
  • Python script loops over all commits it can find (and the existing 3rd party performance results)

@roversch roversch requested a review from mkatliar August 6, 2024 09:09
@roversch roversch changed the base branch from master to run_without_aggregates_only August 6, 2024 09:09
mkatliar
mkatliar approved these changes Aug 6, 2024
View reviewed changes
Copy link
Owner

@mkatliar mkatliar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a minor comment.

Base automatically changed from run_without_aggregates_only to master August 12, 2024 13:04
@roversch roversch merged commit 3dee737 into master Aug 13, 2024
@roversch roversch deleted the compare_commit_performance branch August 13, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkatliar mkatliar mkatliar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roversch @mkatliar