ptr() clean-up
#24
Merged
ptr() clean-up
#24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkatliar
force-pushed
the
ptr_cleanup
branch
3 times, most recently
from
4c9900c to
5dd5638
Compare
roversch
reviewed
Aug 12, 2024
Collaborator
roversch
left a comment
roversch
left a comment
There was a problem hiding this comment.
I can see that you changed the interface a bit (ptr(*A) vs ptr(A)), which I don't understand the reasons for. Could you elaborate?
roversch
approved these changes
Aug 12, 2024
Owner
Author
This is because template <typename MT, bool SO>
inline ptr(blaze::DenseMatrix<MT, SO>& m)
{
return ptr(*m);
}and then the |
- Blaze-specific code moved to blast/blaze
mkatliar
added a commit
that referenced
this pull request
Sep 13, 2024
- Matrix concept and type traits - Clean ptr mess - Blaze-specific code moved to blast/blaze --------- Co-authored-by: Mikhail Katliar <mikhail.katliar@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ptr()implementation independent of specific matrix and vector typesblast/blaze