Conversation
16d1f04 to
9abcdcd
Compare
9abcdcd to
f0d9cd5
Compare
f1206b4 to
ae61f94
Compare
ae61f94 to
03eefec
Compare
Collaborator
|
I can review this in about 10 hours or so ... I have tried to do similar locally and ran into some issues like it seems like you are ... |
e5f7fa7 to
8b9936f
Compare
Owner
Author
|
I ended up getting everything working, so I'm bringing this in. The only big change is that rust-random/getrandom#504 means that downstream WebAssembly users will have to customize |
Collaborator
|
Sorry, I'd ended up sleeping through a lot of the day yesterday after an exhausting week of not enough sleep. Yeah, there's no real choice right now about that. :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #238 , since this is a superset of those changes