Skip to content

Update ALL THE THINGS#270

Merged
mkeeter merged 5 commits intomainfrom
update-all-the-things
Mar 6, 2025
Merged

Update ALL THE THINGS#270
mkeeter merged 5 commits intomainfrom
update-all-the-things

Conversation

@mkeeter
Copy link
Owner

@mkeeter mkeeter commented Mar 5, 2025

Closes #238 , since this is a superset of those changes

@mkeeter mkeeter requested a review from waywardmonkeys March 5, 2025 14:59
@mkeeter mkeeter force-pushed the update-all-the-things branch 4 times, most recently from 16d1f04 to 9abcdcd Compare March 5, 2025 15:38
@mkeeter mkeeter force-pushed the update-all-the-things branch from 9abcdcd to f0d9cd5 Compare March 5, 2025 15:40
@mkeeter mkeeter force-pushed the update-all-the-things branch from f1206b4 to ae61f94 Compare March 5, 2025 16:30
@mkeeter mkeeter force-pushed the update-all-the-things branch from ae61f94 to 03eefec Compare March 5, 2025 16:39
@waywardmonkeys
Copy link
Collaborator

I can review this in about 10 hours or so ... I have tried to do similar locally and ran into some issues like it seems like you are ...

@mkeeter mkeeter force-pushed the update-all-the-things branch from e5f7fa7 to 8b9936f Compare March 6, 2025 20:31
@mkeeter mkeeter merged commit 382fb54 into main Mar 6, 2025
13 checks passed
@mkeeter mkeeter deleted the update-all-the-things branch March 6, 2025 20:40
@mkeeter
Copy link
Owner Author

mkeeter commented Mar 6, 2025

I ended up getting everything working, so I'm bringing this in. The only big change is that rust-random/getrandom#504 means that downstream WebAssembly users will have to customize RUSTFLAGS –I don't love it, but don't see any better alternatives.

@waywardmonkeys
Copy link
Collaborator

Sorry, I'd ended up sleeping through a lot of the day yesterday after an exhausting week of not enough sleep. Yeah, there's no real choice right now about that. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants