Skip to content

Conversation

@ithielnor
Copy link
Contributor

Nested tables inside the floated table header were having odd issues. These changes force floatThead to use only the thead/tbody belonging directly to the selected table(s).

Bug: http://jsfiddle.net/z9t1wmg8/4/

In this example, the size-row gets inserted in the wrong table.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this change required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason

$tbody.before($newHeader);

Was not working at all in this two table scenario. I could not figure it out, so I tried this (which should be the same outcome) and it worked.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill need to find out the exact reason why this change is required before i merge this - not to be a pain - but it might be a symptom of some other bug

@ithielnor
Copy link
Contributor Author

I created a clean test without that change and it seems to work now. It must have been something in my specific use case in my other project.

I've worked around it differently on my project, but it seems to me the $tbody variable is not necessary.

Regardless, here's just the children changes.

mkoryak added a commit that referenced this pull request Mar 10, 2015
Fix table's within tables bug
@mkoryak mkoryak merged commit ab8d402 into mkoryak:master Mar 10, 2015
@mkoryak
Copy link
Owner

mkoryak commented Mar 10, 2015

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants