Skip to content

Fix qmm_t for unaligned cases#923

Merged
awni merged 1 commit intomainfrom
fix-unaligned-qmm_t
Mar 28, 2024
Merged

Fix qmm_t for unaligned cases#923
awni merged 1 commit intomainfrom
fix-unaligned-qmm_t

Conversation

@angeloskath
Copy link
Copy Markdown
Member

Typo in the check in the kernel. Only showed for specific sizes which made it elude our tests.

@angeloskath angeloskath requested review from awni and jagrit06 March 28, 2024 22:27
@angeloskath
Copy link
Copy Markdown
Member Author

Should address the issues at ml-explore/mlx-examples#628 (comment) for the quantized gates.

Copy link
Copy Markdown
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@awni awni mentioned this pull request Mar 28, 2024
@awni awni merged commit 5f9ba30 into main Mar 28, 2024
@awni awni deleted the fix-unaligned-qmm_t branch March 28, 2024 22:34
amirhossein-razlighi pushed a commit to amirhossein-razlighi/mlx that referenced this pull request Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants