Conversation
prmths128
force-pushed
the
oidc_well_known
branch
2 times, most recently
from
f1e51aa to
6719f27
Compare
let the lib do the work instead of building requests and urls uses the well-known endpoint fixes the urls only working on fief
prmths128
force-pushed
the
oidc_well_known
branch
from
6719f27 to
2d9bb95
Compare
inimaz
force-pushed
the
oidc_well_known
branch
from
e29c5b2 to
ff9c46f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1040 +/- ##
==========================================
+ Coverage 68.73% 69.75% +1.02%
==========================================
Files 41 42 +1
Lines 3873 3971 +98
==========================================
+ Hits 2662 2770 +108
+ Misses 1211 1201 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
prmths128
force-pushed
the
oidc_well_known
branch
4 times, most recently
from
e3cf41e to
ca22940
Compare
let the lib do the work instead of building requests and urls uses the well-known endpoint fixes the urls only working on fief
prmths128
force-pushed
the
oidc_well_known
branch
from
8819fe1 to
7b59e19
Compare
SaboniAmine
approved these changes
Feb 15, 2026
Member
SaboniAmine
left a comment
SaboniAmine
left a comment
There was a problem hiding this comment.
LGTM! Finally it's working as expected, thanks Patrick & Iñigo!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let the lib do the work instead of building requests and urls uses the well-known endpoint
fixes the urls only working on fief
Description
Please explain the changes you made here.
Related Issue
Please link to the issue this PR resolves: [issue #]
Motivation and Context
Why is this change required? What problem does it solve?
How Has This Been Tested?
Please describe in detail how you tested your changes.
Screenshots (if appropriate):
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.