Merged
Conversation
stas00
reviewed
Aug 22, 2021
Contributor
stas00
left a comment
There was a problem hiding this comment.
Thank you for adding this new API, @benoit-cty
I added a few language improvement suggestions.
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
Contributor
Author
|
Thanks for the language improvement ! |
SaboniAmine
approved these changes
Aug 22, 2021
stas00
approved these changes
Aug 22, 2021
Contributor
stas00
left a comment
There was a problem hiding this comment.
Tested this last incarnation to work correctly for our needs
Added a few tiny language corrections.
stas00
added a commit
to stas00/Megatron-DeepSpeed
that referenced
this pull request
Aug 22, 2021
Co-authored-by: Stas Bekman <stas00@users.noreply.github.com>
Contributor
|
Should we have |
Contributor
|
Added |
benoit-cty
commented
Aug 23, 2021
vict0rsch
approved these changes
Aug 25, 2021
benoit-cty
commented
Aug 25, 2021
Contributor
Author
benoit-cty
left a comment
There was a problem hiding this comment.
Nice additions Victor 👍
Contributor
|
Thank you everybody who helped to make this happen! |
stas00
added a commit
to bigscience-workshop/Megatron-DeepSpeed
that referenced
this pull request
Aug 25, 2021
* add codecarbon * switch to offline * rework to also restart the tracker at each checkpoint save to ensure as little as possible data is lost * adjust API to match bigscience-workshop/codecarbon#1 * fix logging * new implementation based on mlco2/codecarbon#236 * add test * update requirements
stas00
added a commit
to bigscience-workshop/Megatron-DeepSpeed
that referenced
this pull request
Aug 25, 2021
* add codecarbon * switch to offline * rework to also restart the tracker at each checkpoint save to ensure as little as possible data is lost * adjust API to match bigscience-workshop/codecarbon#1 * fix logging * new implementation based on mlco2/codecarbon#236 * add test * update requirements
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing #217 after talking with @stas00 (see #235) I add a new method
flush()that compute emissions and add them to the CSV, and/or call the API if you use it.I use it in a Keras callback and it do the job of adding a line in the CSV after each epoch.
You can see it in
mnist_callback.pyI've added documentation. But no unit test.