Open
Conversation
When JSONStream tries to read an empty array, it failed because it was trying to parse the empty string. To correct this, we just need to double check in State.END_VALUE_ARRAY that there's actually something to parse. When DiscordChatExporter encounters an empty channel (or DM, voice chat, or otherwise), it still creates a file, but the messages field is set to `[]`. This fix makes sure that we can still parse it. One potential issue is that we may be breaking the way that `pipeline/Time.ts` is used with reference to figuring out the min/max time. Also included tests for this case.
|
i agree it fails to parse empty array |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When JSONStream tries to read an empty array, it failed because it was trying to parse the empty string. To correct this, we just need to double check in
State.END_VALUE_ARRAYthat there's actually something to parse.When DiscordChatExporter encounters an empty channel (or DM, voice chat, or otherwise), it still creates a file, but the
messagesfield is set to[]. This fix makes sure that we can still parse it.Also included tests for this case.
Related: #139