Add logic for subgroup branching #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mulmarta
approved these changes
Mar 23, 2023
Collaborator
mulmarta
left a comment
mulmarta
left a comment
There was a problem hiding this comment.
Passes in the combination wickr-mlspp!
Comment on lines
+18
to
+19
| {"action": "branch", "actor": "alice", "members": ["bob", "charlie", "diana", "eliza"], | ||
| "extensions": [{"extension_type": 3, "extension_data": "AAAA"}, {"extension_type": 5, "extension_data": "AA=="} ]} |
Collaborator
There was a problem hiding this comment.
I wonder if there's a way to check that extensions have been injected? Maybe an RPC GetGCEs where the actor returns repeated Extension extensions? I'm worried that implementation 1 can't generate GCEs and creates a branch without them, which cant be noticed by other implementations
| @@ -0,0 +1,40 @@ | |||
| { | |||
| "scripts": { | |||
Collaborator
There was a problem hiding this comment.
What about other combinations: with extensions and external tree etc. (there are 8 combinations)? Probably doesn't matter much, just for completeness.
This was referenced Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.