FIX #88: Add torch as a build-time dependency in pyproject.toml #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a ModuleNotFoundError: No module named 'torch' that occurs when trying to install the package in a clean environment (e.g., using pip install -e .).
Problem: The setup.py script imports torch at build time. However, because torch was not specified as a build-system requirement, pip would create an isolated build environment that did not have torch installed, causing the installation to fail.
Solution: By adding torch to the build-system.requires list in pyproject.toml, we ensure that pip (or any PEP 517 compliant build tool) installs PyTorch into the isolated build environment before executing setup.py.
This allows the installation to complete successfully without requiring the user to manually install torch beforehand or use the --no-build-isolation flag