Update Open Graph include to support og:image tag#253
Closed
j13k wants to merge 1 commit intommistakes:masterfrom
designconversations:master
Closed
Update Open Graph include to support og:image tag#253j13k wants to merge 1 commit intommistakes:masterfrom designconversations:master
j13k wants to merge 1 commit intommistakes:masterfrom
designconversations:master
Conversation
Owner
|
OpenGraph code has been pulled out of the theme and uses the far superior jekyll-seo-tag plugin. This enhancement will land in #265 once merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FaceBook's Sharing Debugger currently issues a warning about a missing
og:imagetag.For example: https://developers.facebook.com/tools/debug/sharing/?q=https%3A%2F%2Fmmistakes.github.io%2Fso-simple-theme%2F
Solution
This commit contains additional template logic for outputting the missing tag.
Notes
The changes borrow conditional logic from the Twitter Cards block to determine which image URL to output.