Merged
Conversation
Owner
|
Great work on this pull request @alxddh! |
Contributor
Author
Thanks. Looking forward to your follow-up improvement. |
Merged
mmistakes
added a commit
that referenced
this pull request
Oct 30, 2019
## Added - Add light and dark skins. [#347] - Add support for customizable skins. [#347] ## Fixed - Fix security alerts and update [onchange](https://www.npmjs.com/package/onchange) development dependency in `package.json`. [#341]
clarafy
pushed a commit
to clarafy/clarafy.github.io
that referenced
this pull request
Mar 24, 2021
A customizable skin
clarafy
pushed a commit
to clarafy/clarafy.github.io
that referenced
this pull request
Mar 24, 2021
## Added - Add light and dark skins. [mmistakes#347] - Add support for customizable skins. [mmistakes#347] ## Fixed - Fix security alerts and update [onchange](https://www.npmjs.com/package/onchange) development dependency in `package.json`. [mmistakes#341]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an enhancement or feature.
Summary
This PR implements a feature that users can make their skins.
I have moved all color-related properties into a single file
_sass/so-simple/_skin.scss, and made a default skin fileassets/css/skins/default.scss:A skin file would be referenced in the template
head.htmlaccording to the user's configuration:If the user wants to use a custom skin, he or she just needs to copy
default.css, and rename it, and override these color variables.I have also made two additional skins:
light.scssanddark.scss.I think this implementation is very flexible. Users can even select different skins according to different hours in a day, for example, they can write below scripts in their
head-custom.html:Context
#344