Implement an explicit error message#189
Open
charpeni wants to merge 1 commit into
Open
Conversation
commit: |
eaa895b to
66decd2
Compare
Owner
|
I'm not against this - these messages are probably less intimidating for people who aren't yet familiar. Some feedback for this PR to be complete (though I'll still want to think about whether this is definitely better and also whether it should be considered a breaking change):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve error messages for
toBeAny(),toBeString(),toBeNumber(), and other type assertion methods to clearly show expected vs actual typesFixes #179
Before
After
For negated assertions: