Skip to content

fix: incorrect timestamp inserted to duckdb #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yeahbai08 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: incorrect timestamp inserted to duckdb #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions c_src/educkdb_nif.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#define MAX_PATHNAME 512 /* unfortunately not in duckdb.h. */

#define DAY_EPOCH 719528 /* days since {0, 1, 1} -> {1970, 1, 1} */
#define MICS_EPOCH 62167219200000000

#define NIF_NAME "educkdb_nif"

Expand Down Expand Up @@ -1840,7 +1839,7 @@ educkdb_bind_timestamp(ErlNifEnv *env, int argc, const ERL_NIF_TERM argv[]) {
return enif_make_badarg(env);
}

timestamp.micros = value - MICS_EPOCH;
timestamp.micros = value;
if(duckdb_bind_timestamp(stmt->statement, (idx_t) index, timestamp) == DuckDBError) {
return atom_error;
}
Expand Down Expand Up @@ -2351,7 +2350,7 @@ educkdb_append_timestamp(ErlNifEnv *env, int argc, const ERL_NIF_TERM argv[]) {
return enif_make_badarg(env);
}

timestamp.micros = value - MICS_EPOCH;
timestamp.micros = value;
if(duckdb_append_timestamp(appender->appender, timestamp) == DuckDBError) {
return get_appender_error(env, appender->appender);
}
Expand Down