fix: improve request body / content-type handling #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- instead of using the first `requestBody` `content-type`, search for the first supported one. - when none are currently supported, output a `never` type, and a `todo` comment to make this clearer to the user.
mnahkies
added a commit
that referenced
this pull request
Oct 18, 2025
after #349 the integration tests no longer pass when using `joi` as the schema builder, due to: ``` TS2322: Type any is not assignable to type never ``` add an explicit `as never` cast in these instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of using the first
requestBodycontent-type,search for the first supported one.
when none are currently supported, output a
nevertype,and a
todocomment to make this clear to the user.subsequent changes to support for
text/plain,application/x-www-form-urlencoded,application/octet-streamandmultipart/form-dataare planned to follow reasonably quickly, but they might not become supported for every template at once, and this feels like a fairer representationalso start cleaning integration tests before generation