contributor guide improvements

[drammock]

tries to make the contrib guide more approachable.

[larsoner]

A much clearer and more inclusive introduction, +1 for merge from me

[drammock]

quick link to the rendered doc: https://38563-1301584-gh.circle-artifacts.com/0/dev/install/contributing.html

[hoechenberger]

Great initiative! I've added one suggestion

[agramfort]

Thx @drammock

[hoechenberger]

I wonder if we can find a better icon to symbolize bug fixes? The current choice is so much larger than the rest and not monochrome 🤔

[britta-wstnr]

Looks great, @drammock !
While we are at it, would it be okay to nitpick on two small things in the existing text ... ?

[larsoner]

While we are at it, would it be okay to nitpick on two small things in the existing text ... ?

I would say yes, even better if you just want to push a commit to @drammock's branch to fix them!

[drammock]

I wonder if we can find a better icon to symbolize bug fixes? The current choice is so much larger than the rest and not monochrome

We could make it monochrome quite easily. The size might be tricky but should be possible. I'm also open to using Unicode emoji instead of fontawesome, if there are better choices there

While we are at it, would it be okay to nitpick on two small things in the existing text?

Yes go right ahead

[drammock]

@hoechenberger is this better?
https://38648-1301584-gh.circle-artifacts.com/0/dev/install/contributing.html

[britta-wstnr]

I can add the changes tomorrow, did not get to it today. Just quickly from my notes, in case someone wants to beat me to it:
I suggest to change line 60

then `pushing`_ the local changes up to your fork),

to be more explicit:

then `pushing`_ the local changes up to your fork on GitHub),

• I think this is something that is hard to grasp at the beginning, where which version of the code lives.

And then, under Running the test suite, the sidebar (pytest flags) creates a lot of awkward white space as it is longer than the text to its left (and constrained by the code bars). Maybe it could be placed at the end of the paragraph using the whole width?

But as I said - very much nitpicking :)

[hoechenberger]

@hoechenberger is this better?
https://38648-1301584-gh.circle-artifacts.com/0/dev/install/contributing.html

Amazing! I like it!

[larsoner]

Thanks, feel free to merge and backport @drammock