Add fNIRS support to coregistration gui #10122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@larsoner @GuillaumeFavelier @agramfort this is ready for review |
Member
|
diff looks simple and clean. I'll let @GuillaumeFavelier approve first |
GuillaumeFavelier
approved these changes
Dec 13, 2021
Contributor
GuillaumeFavelier
left a comment
GuillaumeFavelier
left a comment
There was a problem hiding this comment.
LGTM as the follow-up PR of #10081
Member
|
merge if happy
… |
Contributor
|
Thank you @rob-luke ! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Replaces #10081 as I struggled with the git merge.
Conversation started over in mne-tools/mne-nirs#419 and specifically this comment from @larsoner mne-tools/mne-nirs#419 (comment)
However, when I ran the coreg guy with fNIRS data no sensors were displayed.
What does this implement/fix?
Enables plotting of fNIRS sources and detectors in the coreg gui