MRG: CoregistrationUI widget improvements (extracted from #10237) #10240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been extracted from mne-tools#10237 to split that PR into smaller, individual ones.
hoechenberger
changed the title
GuillaumeFavelier
suggested changes
Jan 24, 2022
Contributor
GuillaumeFavelier
left a comment
GuillaumeFavelier
left a comment
There was a problem hiding this comment.
We might need to update directory=True to is_directory=True because _add_file_button() is used in the coreg app:
Hopefully it won't create any conflicts with #10237 🤞
Otherwise LGTM, nice work @hoechenberger !
Member
Author
|
@GuillaumeFavelier Thanks, I've pushed a fix for that problem! |
GuillaumeFavelier
approved these changes
Jan 24, 2022
Contributor
GuillaumeFavelier
left a comment
GuillaumeFavelier
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick change 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been extracted from #10237 to split that PR into smaller, individual ones.
cc @GuillaumeFavelier