MRG: In CoregistrationUI, use DigMontage for storing fiducials, factor out fiducials saving into new method, fix trans saving (extracted from #10237) #10241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use a DigMontage to construct the fiducial points before storing them on disk (instead of a custom list of dicts) - Fix transformation saving if file already exists
hoechenberger
changed the title
hoechenberger
changed the title
GuillaumeFavelier
approved these changes
Jan 24, 2022
Contributor
GuillaumeFavelier
left a comment
GuillaumeFavelier
left a comment
There was a problem hiding this comment.
That's solid refactoring and good use of make_dig_montage(), I'm okay with the changes @hoechenberger 👍
Member
|
Thanks @hoechenberger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoregistrationUI._save_mri_fiducials()method in preparation for introduction of a Save buttonPart of the work to split #10237 into smaller chunks
cc @GuillaumeFavelier