MRG: Disable CoregistrationUI widgets while fitting #10283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
approved these changes
Feb 1, 2022
Member
hoechenberger
left a comment
hoechenberger
left a comment
There was a problem hiding this comment.
Awesome, let's merge when green!
hoechenberger
changed the title
Member
|
Background info: We don't want to use to fiddle with the UI (and potentially start another fitting thread!) while a fitting procedure is currently running. So now we're disabling a bunch of widgets for as long as we're fitting. In the future, we may want to show a modal or something. |
agramfort
approved these changes
Feb 1, 2022
Member
agramfort
left a comment
agramfort
left a comment
There was a problem hiding this comment.
@hoechenberger merge when green
Member
|
Thanks @GuillaumeFavelier! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables widgets while fitting (for now fitting and parameter buttons but ultimately we want to disable the whole interface).
cc @hoechenberger