MAINT: Respect activation #10546
Merged
MAINT: Respect activation #10546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
approved these changes
Apr 19, 2022
Member
agramfort
left a comment
agramfort
left a comment
There was a problem hiding this comment.
@GuillaumeFavelier merge if happy
Member
Author
|
I'll merge so that we avoid conflicts (and so that tests run smoothly) but @GuillaumeFavelier feel free to look when you get a chance and I'm happy to revise/revert as necessary! |
larsoner
added a commit
to hoechenberger/mne-python
that referenced
this pull request
Apr 21, 2022
…10520 * upstream/main: MAINT: Respect activation (mne-tools#10546) [ENH, MRG] Add Automatic Muscle Artifact ICA Component Detection (mne-tools#10534)
larsoner
added a commit
to hoechenberger/mne-python
that referenced
this pull request
Apr 21, 2022
…10533 * upstream/main: MAINT: Respect activation (mne-tools#10546) [ENH, MRG] Add Automatic Muscle Artifact ICA Component Detection (mne-tools#10534)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On gnome-shell in Linux, running
pytest mne/vizis really annoying because of focus stealing. This makes our code respect the current code path for deciding whether or not to activate a window when it's shown (usingrcParams). This in turn can be easily controlled inconftestto always be False.