MNT: dialog box icon #10573
Merged
MNT: dialog box icon #10573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Assuming the CIs return green, this is ready to go from my end @agramfort, @larsoner EDIT: Here is a small code snippet to test: Detailsfrom mne.viz.backends.renderer import _get_renderer
renderer = _get_renderer()
dialog = renderer._dialog_create(
title="foo",
text="bar",
info_text="foobar",
callback=lambda x: print('barfoo'),
icon='Information', # <---- new parameter here
buttons=["Ok"],
modal=True,
)
dialog.show()
renderer.show() |
agramfort
approved these changes
Apr 27, 2022
Member
|
Thanks @GuillaumeFavelier ! |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Apr 27, 2022
* upstream/main: MNT: dock area (mne-tools#10575) MNT: dialog box icon (mne-tools#10573) ENH: Add head_source option (mne-tools#10569) fix for broken subjdir (mne-tools#10574) MAINT: Add export functions to env (mne-tools#10563) Add support for BrainVision ahdr/amrk format, as produced by the V-AMP (mne-tools#10515)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR allows setting the Qt dialog box icon (instead of using only⚠️ ). The default remains
'Warning'though.It's part of #10565