-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MRG: Updates to the installation instructions & small tweaks to other parts of the documentation #10583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Did you consider bash session instead? https://pygments.org/languages/ It seems like a more appropriate name for our "BASH prompt" type of examples, but I haven't tested. I can test locally if needed... |
No, is there a difference? |
Ah it seems to add a prompt. I'd rather we didn't do that tbh, it's confusing because the "example prompt" never matches what the users actually see on their own system… |
I think having the |
I'd argue that's only the case for those "who know"; and those who know already know and don't need this. For all others, it's confusing – especially on Windows. |
I disagree on this, I think it helps people who don't know. They see
Again I disagree here -- on Windows if you don't see There might be places where we are command-prompt-agnostic in the sense that commands happen to work in CMD, PowerShell, bash, zsh, tcsh, etc. but I think our docs were not written with this is mind for the most part. |
|
Alright, but we shouldn't have this in the installation instructions, where we lump together the prompts for several operating systems that DO work in all supported shells; e.g. here, the command to create a conda env on macOS, Windows, and Linux: |
I can live with no |
|
Sounds good to me! Do you want to do these changes? |
|
No, feel free since you're working on this stuff |
|
Ouch, turns out Pygments does support The reason why this didn't render correctly in some places was … … because it expects a leading So I'll revert 283a181 and try to fix the occasions where things don't seem to be rendered correctly. |
|
Ok … let's hope this comes back looking nicely. Turns out you're getting it your way, @larsoner ;) |
|
@larsoner Should be good to merge once CI is done!! |
|
Thanks @hoechenberger ! |
|
@larsoner Do you think we can backport this? |
|
Feel free, especially since it looks like #10580 was backported and this PR has fixes for some of the code blocks changed there |
.. code-block:: consoleto... basheverywhere, asPygments, which is reliable for the syntax highlighting, doesn't know anyconsole