[MAINT] Require Bleeding Edge of Sphinx Dependencies to Suppress Warning #10826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please push without skip CI when ready. You can add skip azp and skip actions to have it just run circle |
Contributor
Author
|
I was waiting for executablebooks/sphinx-design#76 to merge, otherwise I don't think it will fix the warnings... |
Contributor
Author
|
Okay maybe let's just merge this if it comes back green |
larsoner
reviewed
Jul 7, 2022
| https://github.com/pydata/pydata-sphinx-theme/archive/cf8b113a496eb458587c0778a423e40c7c1aa22d.zip | ||
| https://github.com/sphinx-gallery/sphinx-gallery/archive/master.zip | ||
| sphinxcontrib-bibtex>=2.1.2 | ||
| git+https://github.com/mcmtroffaes/sphinxcontrib-bibtex.git |
Member
There was a problem hiding this comment.
git+ is not as good as the archive or zipball variants of a direct https URL, because it actually does a full git clone IIRC
Contributor
Author
There was a problem hiding this comment.
Hmmm maybe we should just close since the CIs pass and wait for their releases
Member
There was a problem hiding this comment.
Agreed, I think we don't have to rush on this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes related to #10825.