BUG: Avoid warning in report.add_ica #11232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
approved these changes
Oct 9, 2022
Member
|
@larsoner I let you merge if the CI failures are expected. 🙏 |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Oct 11, 2022
* upstream/main: BUG: Avoid warning in report.add_ica (mne-tools#11232) testing new features of website theme [circle deploy] (mne-tools#11033) BUG: Fix regression with run_subprocess (mne-tools#11230) DOC: fix mne-kit-gui package name (mne-tools#11231)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over in mne-bids-pipeline I'm trying to squash all warnings, but I get:
This adds a
on_baseline='warn'that we can set toon_baseline='reapply'to avoid this and reapply the baseline afterica.apply. Internallyreport.add_icawill always useon_baseline='reapply'forica.plot_overlay, but in principle we could expose this as a parameter.Okay for you @agramfort ?