Skip to content

Conversation

@larsoner
Copy link
Member

@larsoner larsoner commented Mar 16, 2023

Just the start of a proof-of-concept for #11564, in addition to the lines I removed already in #11557. Would still need:

@larsoner larsoner changed the title WIP: Try adding as core dep WIP: Try adding nibabel as a required dependency Mar 16, 2023
@larsoner larsoner changed the title WIP: Try adding nibabel as a required dependency MAINT: Add nibabel as a required dependency Mar 16, 2023
@larsoner larsoner marked this pull request as ready for review March 16, 2023 18:14
@larsoner larsoner added this to the 1.4 milestone Mar 16, 2023
@drammock
Copy link
Member

I think after discussion with @agramfort @britta-wstnr @larsoner and myself today, it was agreed to abandon this idea, closing as not planned. Rationale is that adding core deps can be burdensome for users in a tightly managed environment (they may need permission from IT to get nibabel added, for example).

@drammock drammock closed this Mar 17, 2023
@larsoner
Copy link
Member Author

Indeed I'll open another PR soon to add more requires_nibabel to our code

@larsoner larsoner deleted the nibabel branch March 17, 2023 22:15
@larsoner larsoner mentioned this pull request Jul 6, 2023
- NumPy >= 1.20.2
- SciPy >= 1.6.3
- Matplotlib >= 3.4.0
- NiBabel >= 3.2.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we discovered this in HNN. Looks like nibabel is a core dependency now but it's not reflected in the setup.py: https://github.com/mne-tools/mne-python/blob/main/requirements_base.txt

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give a traceback? We ended up not making it a core dependency

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you go: jonescompneurolab/hnn-core#649 (comment)

should we be installing nibabel in our CIs separately?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, nibabel is an optional dependency not a core one, so you have to install it separately. PR welcome to change the wording of the error message to say something about it being optional and to consider installing it

raise ImportError(f"The {lib} package{extra} is required to {what}, " f"{why}")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants