Skip to content

API: Port ieeg gui over to mne-gui-addons and add tfr gui example #11616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larsoner merged 17 commits into from
Apr 13, 2023
Merged

API: Port ieeg gui over to mne-gui-addons and add tfr gui example #11616

larsoner merged 17 commits into from
Apr 13, 2023

Conversation

@alexrockhill
Copy link
Contributor

@alexrockhill alexrockhill commented Apr 3, 2023

Deprecates mne.gui.locate_ieeg and moves it to mne_gui_addons

@larsoner
Copy link
Member

larsoner commented Apr 3, 2023

For deprecation we shouldn't delete the code now. We now we should try/except an import and if it fails fall back to our code. Then once we release 1.4 and are in the 1.5.dev0 we can delete the old code

@alexrockhill
Copy link
Contributor Author

alexrockhill commented Apr 3, 2023

Sounds good

@alexrockhill
Copy link
Contributor Author

alexrockhill commented Apr 3, 2023

This should fail CIs until mne-gui-addons is added to conda-forge in a couple days, then I will try and rerun.

larsoner
larsoner reviewed Apr 4, 2023
View reviewed changes
@alexrockhill @larsoner
Update mne/gui/__init__.py
047d270 
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
larsoner
larsoner reviewed Apr 12, 2023
View reviewed changes
@larsoner larsoner changed the title [MAINT, WIP] Port ieeg gui over to mne-gui-addons and add tfr gui example API: Port ieeg gui over to mne-gui-addons and add tfr gui example Apr 12, 2023
larsoner added 5 commits April 12, 2023 14:09
@larsoner
WIP: Link
ae56546
@larsoner
Merge remote-tracking branch 'upstream/main' into gui
b9657d8 
* upstream/main:
  MAINT: Add token [ci skip] (mne-tools#11622)
  API: One cycle of backward compat (mne-tools#11621)
  MAINT: Use git rather than zipball (mne-tools#11620)
  ENH: Speed up code a bit (mne-tools#11614)
@larsoner
FIX: Link
d040f18
@larsoner
FIX: Restore
cffa99e
@larsoner
FIX: Add
404a145
@larsoner larsoner mentioned this pull request Apr 12, 2023
Closed
8 tasks
@larsoner larsoner enabled auto-merge (squash) April 12, 2023 18:29
@larsoner larsoner mentioned this pull request Apr 13, 2023
Closed
@larsoner larsoner merged commit d0cf4db into mne-tools:main Apr 13, 2023
@alexrockhill
Copy link
Contributor Author

alexrockhill commented Apr 13, 2023

Thanks for finishing the PR @larsoner

@alexrockhill alexrockhill deleted the gui branch April 13, 2023 14:29
@drammock drammock mentioned this pull request Apr 13, 2023
Merged
larsoner added a commit to cbrnr/mne-python that referenced this pull request Apr 21, 2023
@larsoner
Merge remote-tracking branch 'upstream/main' into precommit
1770b7b 
* upstream/main: (50 commits)
  BUG: Fix bug with paths (mne-tools#11639)
  MAINT: Report download time and size (mne-tools#11635)
  MRG: Allow retrieval of channel names via make_1020_channel_selections() (mne-tools#11632)
  Fix index name in to_data_frame()'s docstring (mne-tools#11457)
  MAINT: Use VTK prerelease wheels in pre jobs (mne-tools#11629)
  ENH: Allow gradient compensated data in maxwell_filter (mne-tools#10554)
  make test compatible with future pandas (mne-tools#11625)
  Display SVG figures correctly in Report (mne-tools#11623)
  API: Port ieeg gui over to mne-gui-addons and add tfr gui example (mne-tools#11616)
  MAINT: Add token [ci skip] (mne-tools#11622)
  API: One cycle of backward compat (mne-tools#11621)
  MAINT: Use git rather than zipball (mne-tools#11620)
  ENH: Speed up code a bit (mne-tools#11614)
  [BUG, MRG] Don't modify info in place for transform points (mne-tools#11612)
  [BUG, MRG] Fix topomap extra plot generated, add util to check a range (mne-tools#11607)
  ENH: Add mne-bids-pipeline to mne sys_info (mne-tools#11606)
  MAINT: `coding: utf-8` is implicit in Python 3 (mne-tools#11599)
  ENH: Read eyetracking data (Eyelink) (Fork of mne-tools#10855 ) (mne-tools#11152)
  MAINT: In Python 3, do not prefix literals with `u` (mne-tools#11604)
  MAINT: object is an implicit base for all classes (mne-tools#11601)
  ...
larsoner added a commit to larsoner/mne-python that referenced this pull request Apr 25, 2023
@larsoner
Merge remote-tracking branch 'upstream/main' into cola5
7c44d72 
* upstream/main: (152 commits)
  FIX: missing channels/fiducials can be np.nan (mne-tools#11634)
  use py3.10 in precommit config (mne-tools#11648)
  MAINT: Unify GH Actions pytest (mne-tools#11644)
  MRG: Rename "Discourse" link in top navigation to "Forum" [ci skip] (mne-tools#11649)
  ENH: Add support for Harmonic Field correction (mne-tools#11536)
  Add pre-commit (mne-tools#11541)
  BUG: Fix bug with paths (mne-tools#11639)
  MAINT: Report download time and size (mne-tools#11635)
  MRG: Allow retrieval of channel names via make_1020_channel_selections() (mne-tools#11632)
  Fix index name in to_data_frame()'s docstring (mne-tools#11457)
  MAINT: Use VTK prerelease wheels in pre jobs (mne-tools#11629)
  ENH: Allow gradient compensated data in maxwell_filter (mne-tools#10554)
  make test compatible with future pandas (mne-tools#11625)
  Display SVG figures correctly in Report (mne-tools#11623)
  API: Port ieeg gui over to mne-gui-addons and add tfr gui example (mne-tools#11616)
  MAINT: Add token [ci skip] (mne-tools#11622)
  API: One cycle of backward compat (mne-tools#11621)
  MAINT: Use git rather than zipball (mne-tools#11620)
  ENH: Speed up code a bit (mne-tools#11614)
  [BUG, MRG] Don't modify info in place for transform points (mne-tools#11612)
  ...
larsoner added a commit to larsoner/mne-python that referenced this pull request Apr 25, 2023
@larsoner
Merge remote-tracking branch 'upstream/main' into kernel
bbc55af 
* upstream/main: (117 commits)
  FIX: missing channels/fiducials can be np.nan (mne-tools#11634)
  use py3.10 in precommit config (mne-tools#11648)
  MAINT: Unify GH Actions pytest (mne-tools#11644)
  MRG: Rename "Discourse" link in top navigation to "Forum" [ci skip] (mne-tools#11649)
  ENH: Add support for Harmonic Field correction (mne-tools#11536)
  Add pre-commit (mne-tools#11541)
  BUG: Fix bug with paths (mne-tools#11639)
  MAINT: Report download time and size (mne-tools#11635)
  MRG: Allow retrieval of channel names via make_1020_channel_selections() (mne-tools#11632)
  Fix index name in to_data_frame()'s docstring (mne-tools#11457)
  MAINT: Use VTK prerelease wheels in pre jobs (mne-tools#11629)
  ENH: Allow gradient compensated data in maxwell_filter (mne-tools#10554)
  make test compatible with future pandas (mne-tools#11625)
  Display SVG figures correctly in Report (mne-tools#11623)
  API: Port ieeg gui over to mne-gui-addons and add tfr gui example (mne-tools#11616)
  MAINT: Add token [ci skip] (mne-tools#11622)
  API: One cycle of backward compat (mne-tools#11621)
  MAINT: Use git rather than zipball (mne-tools#11620)
  ENH: Speed up code a bit (mne-tools#11614)
  [BUG, MRG] Don't modify info in place for transform points (mne-tools#11612)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner larsoner left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alexrockhill @larsoner