FIX: Set UseHighDpiPixmaps only for PyQt5 and PySide2 #11662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
florin-pop
commented
Apr 28, 2023
larsoner
reviewed
Apr 28, 2023
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Can you just add a quick line to doc/changes/latest.inc with :newcontrib: to the top of the BUG section about improving compat with Qt6 and add your name to doc/changes/names.inc? Then after removing the try I think we can merge!
Contributor
Author
|
Thank you @larsoner! |
larsoner
approved these changes
Apr 28, 2023
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Will merge when green, thanks @florin-pop !
larsoner
reviewed
Apr 28, 2023
Member
|
🎉 newcontrib 🎉 |
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In mne-tools/mne-nirs#510 we migrated to
PySide6.When calling
setAttribute(Qt.AA_UseHighDpiPixmaps)there is a warning as this attribute was deprecated in QT6 and it has no effect as HiDPI is enabled by default.What does this implement/fix?
One way of solving the issue, as suggested by @larsoner in mne-tools/mne-nirs#510 (comment) is to check the QT version and set the attribute conditionally.
Contributed with ❤️ by AE Studio