DOC: Fix table formatting #11663
Merged
DOC: Fix table formatting #11663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drammock
approved these changes
Apr 28, 2023
Member
drammock
left a comment
drammock
left a comment
There was a problem hiding this comment.
I find it somewhat jarring that different rows have different text colors in the table here. Was that intentional? alternating rows are either (206,206,206) or (255,255,255) in dark mode. (the same is true in light mode: 0,0,0 vs 50,50,50 but to me it's much less noticable in light mode). WDYT?
(regardless I think we can merge this as-is; I agree that a proper fix should land at the theme level)
Member
Author
Pushed a fix for that and locally tested it, merging since CIs won't tell us much here! |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
May 1, 2023
* upstream/main: BUG: Fix bug with annotation rename (mne-tools#11666) DOC: Fix table formatting (mne-tools#11663)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11571
@drammock I think I lean toward this being a pydata-sphinx-theme issue, if you agree I can open a near-dup of #11571 over there (or feel free to do it)