-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update website conf #11675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update website conf #11675
Conversation
00cb92c to
839c424
Compare
|
Are we supposed to get a warning when viewing https://mne.tools/1.1/index.html for example that it's not latest stable? If not we might want to add it at some point. Accidentally looking at old docs can be bad/misleading. I actually kind of liked the "breadcrumbs" assuming this is what they are (on But I can live without them, too. Front page spacing looks good. So feel free to merge if you're happy @drammock ! |
|
... I also don't currently get a warning banner on https://mne.tools/dev/ but maybe this PR will fix that |
hopefully this PR fixes that by letting the theme JS run before the versionwarning JS, so that versionwarning actually has a version dropdown menu to query. |
we can consider adding them back if others also like them; personally I think they make it too busy/crowded. They're a pretty new feature of the theme so there might still be some kinks to work out too (i.e. not super thoroughly tested yet). |
* upstream/main: (32 commits) MAINT: Update download buttons [skip azp] [skip actions] [skip cirrus] Fix canvas.draw() in callback (mne-tools#11697) Remove recursion in plot_ica_components and use context manager for plt.ion/plt.ioff (mne-tools#11696) Update affiliation (mne-tools#11695) BUG: Fix bug with fwd restriction (mne-tools#11694) MRG: Suggest using "conda rename" in MNE updating instructions (mne-tools#11692) FIX: Regex [ci skip] MAINT: Apply deprecations [circle deploy] (mne-tools#11687) MAINT: Release 1.4.0 (mne-tools#11686) Trap music (mne-tools#11679) Fix call to plot_tfr_topomap from interactive AverageTFR.plot_topo function (mne-tools#11683) silence spectrum plot warning in examples/tutorials [circle full] (mne-tools#11682) Spectrum plot picks (mne-tools#11680) Update website conf (mne-tools#11675) BUG: Fix bug with MF LCMV rank (mne-tools#11664) ENH: Change known_config_types to dict (mne-tools#11166) MAINT: Improve README (mne-tools#11673) MAINT: Add to git-blame-ignore-revs [circle front] MAINT: Run black on codebase MAINT: Use black ...

This handles all the config changes needed for pydata-sphinx-theme 0.13.3. I still haven't fixed the tile spacing of the homepage image tiles, so still in draft mode. once I think that's fixed will do a
circle front.Ideally needs mne-tools/mne-tools.github.io#27 to be merged first, but the sequencing doesn't really matter (just makes it easier to test the versionwarning changes here if they're already merged in)