-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Standard Montage: easycap-M43 #11742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@dasdiptyajit the CI checks come back with a failure. In particular, this line need to be updated to say 28, instead of 27. Having that said, I haven't been a very good example by just pushing a commit and letting the CI run before checking locally that it would pass. I would ask you kindly to read our contributor guide, in particular the parts about setting up you local development environment, so that you can run the full test suite locally. Ideally, you would (in the future) always:
That way we can minimize the time that our (paid) CI services run. Thanks again for your contribution, and I believe that this is the last check that needs to be fixed before a merge. |
|
@sappelhoff No problem. I will follow your advice and try to resolve the issue soon. This is also my first time contributing to MNE, so I am getting familiar with the setup :) |
d13ed40 to
ebf05fb
Compare
|
I am fixing this. My commits sign were apparently unverified. My bad. |
|
closing in favor of #11744 |
Fixes: #11737
What does this implement/fix?