Skip to content

Conversation

@dasdiptyajit
Copy link
Contributor

Fixes: #11737

What does this implement/fix?

  • Creates a standard montage layout for easycap-M43 system.

@sappelhoff
Copy link
Member

@dasdiptyajit the CI checks come back with a failure. In particular, this line need to be updated to say 28, instead of 27.

https://github.com/dasdiptyajit/mne-python/blob/d13ed40e6a77d46ba2419961532340e6a75d4261/mne/channels/tests/test_montage.py#L1918

Having that said, I haven't been a very good example by just pushing a commit and letting the CI run before checking locally that it would pass.

I would ask you kindly to read our contributor guide, in particular the parts about setting up you local development environment, so that you can run the full test suite locally. Ideally, you would (in the future) always:

  1. make several commits locally (as many as needed)
  2. test them locally
  3. push them to the remote

That way we can minimize the time that our (paid) CI services run.

Thanks again for your contribution, and I believe that this is the last check that needs to be fixed before a merge.

@dasdiptyajit
Copy link
Contributor Author

@sappelhoff No problem. I will follow your advice and try to resolve the issue soon. This is also my first time contributing to MNE, so I am getting familiar with the setup :)

@dasdiptyajit dasdiptyajit force-pushed the Montage-easycap-M43-dev branch 4 times, most recently from d13ed40 to ebf05fb Compare June 20, 2023 10:01
@dasdiptyajit
Copy link
Contributor Author

I am fixing this. My commits sign were apparently unverified. My bad.

@sappelhoff
Copy link
Member

closing in favor of #11744

@sappelhoff sappelhoff closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standard Montage: easycap-M43 (63 equidistant electrodes)

2 participants