DOC: Morlet wavelet length in tfr_morlet #12073
Merged
+50
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves the docstring of mne.time_frequency.tfr_morlet and mne.time_frequency.tfr_array_morlet. An explanation on the length of the Morlet wavelet for time-frequency representation is added. Closes mne-tools#11645 .
ruuskas
requested review from
adam2392,
drammock and
mscheltienne
as code owners
Member
|
FYI CircleCI will fail with a warning about bool builting linking until #12068 is merged |
ruuskas
changed the title
Member
|
Looks like there is a failure in i.e. it's no longer alphabetical |
Contributor
Author
|
The robots seem to be happy, how about the humans? @drammock |
drammock
reviewed
Oct 5, 2023
Member
drammock
left a comment
drammock
left a comment
There was a problem hiding this comment.
very nice! A few minor formatting tweaks; I'm not 100% sure that all of the extra blank lines are necessary (but at least some of them are). Let's double-check the rendered docs again after rebuild.
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Contributor
Author
|
Seems that the CIs failing are unrelated @drammock (?) |
Member
ruuskas
requested review from
agramfort,
dengemann and
larsoner
as code owners
larsoner
approved these changes
Oct 6, 2023
Member
|
Marking for merge when green, thanks @ruuskas ! |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Oct 10, 2023
* upstream/main: (37 commits) Use constrained layout in matplotlib visualization (mne-tools#12050) Add raw stc (mne-tools#12001) [MRG] update codeowners (mne-tools#12089) DOC: Morlet wavelet length in tfr_morlet (mne-tools#12073) BUG: Fix bug with mne browser backend (mne-tools#12078) Cache avatars (mne-tools#12077) BUG: Fix bug with ch_name resolution (mne-tools#12086) add unicode roundtrip for FIF (mne-tools#12080) add Ivan to names.inc (mne-tools#12081) MAINT: Work around PySide 6.5.3 event loop error (mne-tools#12076) mne-tools#11608, buggfix and docstring update (mne-tools#12066) MAINT: Fix broken examples (mne-tools#12074) Add UI Event linking to DraggableColorbar (mne-tools#12057) handle lazy loading through .pyi type stubs (mne-tools#12072) BUG: Fix bug with sensor_colors (mne-tools#12068) clean up some deprecations (mne-tools#12067) Allow not dropping bads when creating or plotting Spectrum objs (mne-tools#12006) Collapsible html repr for raw/info (mne-tools#12064) BUG: Fix bug with pickling MNEBadsList (mne-tools#12063) add details for Denis (mne-tools#12065) ...
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
Co-authored-by: Daniel McCloy <dan@mccloy.info> Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11645.
This PR adds clarification of the Morlet wavelet temporal window length used with
mne.time_frequency.tfr_array_morletandmne.time_frequency.tfr_morlet.