ENH: Add MEG sensor option to coreg #12098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
requested review from
agramfort,
dengemann and
drammock
as code owners
7 tasks
Member
Author
|
@jasmainak could you look? I think you requested this in #11276 |
larsoner
requested review from
jasmainak
and removed request for
agramfort and
dengemann
Member
|
I'm seeing the sensors disappear / replaced by a greyish square when I zoom in. Is that expected? coreg.webm |
Member
Author
|
Hmm... could be the depth peeling failing or the view frustum doing something odd. But more likely it's "just" a rendering bug of some sort for your GPU and/or version of VTK, on macOS I don't see it: 
I'll commit the typo fix and mark for merge when green! |
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows plotting the MEG sensors in addition to the helmet, and also should fix the rendering bugs you were seeing during the sprint @wmvanvliet by introducing a 1mm offset between the MEGIN sensor geometries which otherwise are perfectly coincident (which is bad news when using translucent geometry, at least when using depth peeling which is otherwise generally a good idea):
As an aside @wmvanvliet I noticed something when debugging the rendering issue -- if you want your rendering to be (closer to) as smooth as MNE-C you can disable depth peeling and it's much faster. But it has the side effect of messing up translucent geometry.