Skip to content

Conversation

@withmywoessner
Copy link
Contributor

Reference issue

Example: Fixes #12191.

What does this implement/fix?

Add title to topoplot in plot_compare_evokeds

Additional information

Any additional information you think is important.

@withmywoessner
Copy link
Contributor Author

withmywoessner commented Nov 10, 2023

The title is too small @larsoner. Any preference for how it should be formatted?
image

@withmywoessner withmywoessner marked this pull request as draft November 10, 2023 23:29
@withmywoessner
Copy link
Contributor Author

withmywoessner commented Nov 11, 2023

My solution was a bit sloppy so I can try something else if needed

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is too small @larsoner. Any preference for how it should be formatted?

I think it's okay as is. Users can set suptitle font size via rcParams for example and we should just live with whatever it is

withmywoessner and others added 3 commits November 13, 2023 13:27
@withmywoessner withmywoessner marked this pull request as ready for review November 13, 2023 19:39
@withmywoessner
Copy link
Contributor Author

Ready for merge @larsoner! The function didn't autocomplete when I typed it in in devel so I hope I specified it correctly.

@larsoner
Copy link
Member

Can you go to https://app.circleci.com/pipelines/github/mne-tools/mne-python/21836/workflows/7c69bd2c-835a-428b-b60b-1fe65b988098/jobs/61390 and log in with GitHub? It will allow CircleCI to build your PRs

@withmywoessner
Copy link
Contributor Author

I just did it now:
image

@withmywoessner
Copy link
Contributor Author

Sorry, I had to merge again. I am not sure why the CircleCI test is failing. I logged in.

@withmywoessner
Copy link
Contributor Author

I think there is something wrong with the tests. All of my PRs are failing. I ran them locally:

============================= test session starts ==============================
platform linux -- Python 3.11.6, pytest-7.4.3, pluggy-1.3.0
PyQt5 5.15.9 -- Qt runtime 5.15.8 -- Qt compiled 5.15.8
rootdir: /home/woess/workspace/git_projects/mne-python
configfile: pyproject.toml
plugins: qt-4.2.0, cov-4.1.0, timeout-2.2.0, anyio-4.0.0, harvest-1.10.4
collected 34 items

mne-python/mne/viz/_brain/tests/test_brain.py .......................... [ 76%]
........                                                                 [100%]



--- generated xml file: /home/woess/workspace/git_projects/junit-results.xml ---

============================ slowest 1 test module =============================
199.51s total  mne/viz/_brain/tests/
============================= slowest 20 durations =============================
13.46s call     mne/viz/_brain/tests/test_brain.py::test_brain_traces[pyvistaqt-vector-both]
12.85s call     mne/viz/_brain/tests/test_brain.py::test_brain_init[pyvistaqt]
11.35s call     mne/viz/_brain/tests/test_brain.py::test_brain_traces[pyvistaqt-mixed-both]
11.31s call     mne/viz/_brain/tests/test_brain.py::test_brain_traces[pyvistaqt-mixed-split]
9.82s call     mne/viz/_brain/tests/test_brain.py::test_brain_traces[pyvistaqt-mixed-lh]
9.46s call     mne/viz/_brain/tests/test_brain.py::test_brain_traces[pyvistaqt-surface-split]
9.45s call     mne/viz/_brain/tests/test_brain.py::test_brain_time_viewer[pyvistaqt]
9.44s call     mne/viz/_brain/tests/test_brain.py::test_brain_traces[pyvistaqt-surface-both]
9.40s call     mne/viz/_brain/tests/test_brain.py::test_brain_traces[pyvistaqt-vector-split]
8.74s call     mne/viz/_brain/tests/test_brain.py::test_brain_traces[pyvistaqt-vector-rh]
8.57s call     mne/viz/_brain/tests/test_brain.py::test_brain_traces[pyvistaqt-mixed-rh]
8.25s call     mne/viz/_brain/tests/test_brain.py::test_brain_traces[pyvistaqt-surface-rh]
7.61s call     mne/viz/_brain/tests/test_brain.py::test_brain_traces[pyvistaqt-vector-lh]
7.47s call     mne/viz/_brain/tests/test_brain.py::test_brain_save_movie[pyvistaqt]
6.73s call     mne/viz/_brain/tests/test_brain.py::test_brain_traces[pyvistaqt-volume-lh]
6.50s call     mne/viz/_brain/tests/test_brain.py::test_brain_traces[pyvistaqt-volume-split]
6.22s call     mne/viz/_brain/tests/test_brain.py::test_brain_traces[pyvistaqt-volume-both]
6.21s call     mne/viz/_brain/tests/test_brain.py::test_brain_traces[pyvistaqt-surface-lh]
5.70s call     mne/viz/_brain/tests/test_brain.py::test_brain_traces[pyvistaqt-volume-rh]
5.49s call     mne/viz/_brain/tests/test_brain.py::test_brain_data_gc[pyvistaqt]
======================== 34 passed in 227.22s (0:03:47) ========================

@larsoner
Copy link
Member

Failures are unrelated and should be fixed in #12178

@larsoner larsoner merged commit a91f582 into mne-tools:main Nov 14, 2023
@larsoner
Copy link
Member

Thanks @withmywoessner !

snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
…ne-tools#12192)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

plot_compare_evokeds doesn't display title when using axes='topo'

2 participants