ENH: increment testing ds version + hash #12200
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This will cause CIs to fail, right? |
Contributor
Author
|
Huh, oh right, maybe I messed up the order. Shall I PR the |
Member
|
You can just push commits here to fix the reader and increment the testing version |
Contributor
Author
|
OK, thanks! I think I see now where I got confused. Might open a new PR on my local branch with test_neuralynx and the version + hash fix there (might have made a history mess locally on this branch). Updating my local mne-testing-dataset now, will test, then PR if it works. |
Member
|
That would work too |
Member
|
Closing for #11969 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
ENH: Follow up to the PR in mne-testing-repo and the new testing dataset release.
What does this implement/fix?
Incrementing testing dataset version to 0.150 and setting the new hash.