equalize epoch counts for EpochsTFR #12207
Conversation
CarinaFo
requested review from
adam2392,
agramfort,
dengemann,
drammock and
mscheltienne
as code owners
CarinaFo
changed the title
CarinaFo
changed the title
CarinaFo
changed the title
CarinaFo
changed the title
|
+1 to move the |
…into equalize_epochs_tfr
…into equalize_epochs_tfr
for more information, see https://pre-commit.ci
removing duplicate changelog entry. The number in the changelog filename should be the PR number, not the number of the issue that it fixes.
Notice the comments at the top of the file: "file generated by setuptools_scm; don't change, don't track in version control"
drammock
left a comment
drammock
left a comment
There was a problem hiding this comment.
FYI I deleted 2 files: the duplicate changelog entry (the one that had the issue number in its filename) and the file mne/_version.py (which is auto-generated and isn't supposed to get committed to GitHub). Other than that just a few small suggestions that should hopefully get CIs to pass.
drammock
changed the title
|
@larsoner this one is all green and ready for a second pair of eyes. |
…into equalize_epochs_tfr
…hub.com:CarinaFo/mne-python into equalize_epochs_tfr
|
Should I wait for the auto-merge before I close the PR? |
Don't close the PR. It will automatically close when it's merged... But there are 2 failing tests that are preventing auto merge. I'll look tomorrow, they may be unrelated to this PR (and thus you wouldn't need to fix them here) but let's be sure |
Co-authored-by: Daniel McCloy <dan@mccloy.info>
4 participants
fixed #11776
mne.epoch.Epochs.equalize_epoch_counts allows EpochsTFR as inputs