Skip to content

Conversation

@drammock
Copy link
Member

closes #12214

@drammock drammock requested a review from larsoner as a code owner November 15, 2023 20:40
@larsoner
Copy link
Member

Or we wait until tomorrow for mne-tools/mne-bids#1192

@drammock
Copy link
Member Author

Or we wait until tomorrow for mne-tools/mne-bids#1192

Fair enough... but isn't there a chance a similar situation will happen again? API change in MNE-Python -> MNE-Python examples that use MNE-BIDS fail until next MNE-BIDS release. Is the plan then "push out an MNE-BIDS point release whenever this occurs"?

@larsoner
Copy link
Member

. but isn't there a chance a similar situation will happen again?

Yes but hopefully it's fairly rare. It's also not just isolated to MNE-BIDS but also mne-gui-addons, etc. I think it makes sense to switch to dev, add to conf.py:reset_modules ignore list, or push a point release when it does happen -- typicall we just go the dev route when this happens. But I think it makes sense to stick to stable versions as much as possible.

@larsoner larsoner merged commit 239e574 into mne-tools:main Nov 15, 2023
@larsoner
Copy link
Member

... so we can merge this for now, then in some follow-up PR sometime after tomorrow, revert it to use stable again. In the meantime merging this saves us each one angry email from CircleCI tomorrow morning :)

@drammock drammock deleted the fix-pick_types branch November 15, 2023 21:23
snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CircleCI should get current main of ecosystem packages

2 participants