Fix pyproject.toml setuptools configuration #12240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My linter showed the entire pyproject.toml file in red, so I went on the investigate. Turns out both section and key names were incorrect. I fixed that. I also removed the zip-safe flag because it's been deprecated for many years and isn't used anymore. BTW the linter I'm using is https://marketplace.visualstudio.com/items?itemName=tamasfe.even-better-toml
Contributor
|
Thanks @hoechenberger! |
larsoner
added a commit
to hoechenberger/mne-python
that referenced
this pull request
Nov 27, 2023
* upstream/main: Add some omitted dependencies to "full" and "doc" variants (mne-tools#12235) Fix pyproject.toml setuptools configuration (mne-tools#12240) FIX: Allow eyetrack channels to be used with plot_compare_evoked (mne-tools#12190)
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My linter showed the entire pyproject.toml file in red, so I went on the investigate.
Turns out both section and key names were incorrect. I fixed that. I also removed the zip-safe flag because it's been deprecated for many years and isn't used anymore.
BTW the linter I'm using is https://marketplace.visualstudio.com/items?itemName=tamasfe.even-better-toml
It's pyproject.toml-aware.