ENH: Add polyphase resampling #12268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
requested review from
agramfort,
cbrnr,
dengemann,
drammock and
mscheltienne
as code owners
larsoner
commented
Dec 6, 2023
drammock
approved these changes
Dec 6, 2023
Member
There was a problem hiding this comment.
sphinx_gallery_thumbnail_number=3 is visible in the rendered tutorial, can you fix that here please?
Member
There was a problem hiding this comment.
there are some things about this tutorial that don't quite make sense now, but it appears to be due to earlier changes to the file (not anything you've done here). I'll open a separate issue about it (#12271).
Co-authored-by: Daniel McCloy <dan@mccloy.info>
6 tasks
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo/modernization of #5136 to follow the plan outlined in #11408 (comment) to allow principled fixing of #10447.