Clean up .gitignore a bit and fix packaging #12281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
requested review from
agramfort,
dengemann,
drammock and
larsoner
as code owners
Fixes packaging bug introduced in mne-tools#12269 Addresses the issues raised in: mne-tools/mne-bids-pipeline#825 (comment) mne-tools/mne-bids#1206 (comment) Ultimately, we should start testing the installed package(s), not simply fire up the tests from the root of the checked-out repo.
hoechenberger
force-pushed
the
hatchling-fixup
branch
from
e00d854 to
a6dde70
Compare
larsoner
reviewed
Dec 8, 2023
Member
Author
|
@larsoner I have tried one possible approach following your comment. WDYT? |
Member
|
Okay with my test commit locally I get: Hopefully GHA conda/mamba CIs fail the same way here, then we'll know we're testing properly |
Member
Author
|
Great, thanks! |
Member
|
Okay it's successfully failing: on to some fixes... |
hoechenberger
commented
Dec 8, 2023
Member
Author
|
@larsoner I think we're good here! I managed to simplify the inclusion list |
Member
|
Thanks @hoechenberger ! |
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes packaging bug introduced in #12269
Addresses the issues raised in:
mne-tools/mne-bids-pipeline#825 (comment)
mne-tools/mne-bids#1206 (comment)
Ultimately, we should start testing the installed package(s), not simply
fire up the tests from the root of the checked-out repo.
cc @cbrnr @sappelhoff