Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes #12413.
What does this implement/fix
So far, to insert gap data (0's representing missing samples), the
AnalogSignalGapclass with a dummyload()method was defined and used to mirror theneo.AnalogSignalProxyobject which loads recorded samples from disk.As of v13,
neoallows onlyAnalogSignal/AnalogSignalProxytypes to be appended toSegment.analogsignalsattribute. To fix this, we drop the over-engineeredAnalogSignalGapclass. Instead, we create zero-arrays directly withAnalogSignaland use a simple control statement to distinguish loading real data (viaAnalogSignalProxy.load().magnitude) and padding 0's (viaAnalogSignal.magnitude) when looping over segments and creating the output data array.