Skip to content

Conversation

@nabilalibou
Copy link
Contributor

@nabilalibou nabilalibou commented Feb 7, 2024

Fixes #12407

Label no-changelog-entry-needed to add i think

average reference to be set.
Whether a custom (=other than an average projector) reference has been
applied to the EEG data. This flag is checked by some algorithms that
require an average reference to be set.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct for what it is now but FYI not for what it should be. See #12369. I'll update this when I take care of that PR I think

Copy link
Contributor Author

@nabilalibou nabilalibou Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is just to be coherent with my other PR #12420 but i'll keep an eye on #12369 and will remodify the doc if necessary

@drammock drammock merged commit e05e77c into mne-tools:main Feb 7, 2024
@drammock
Copy link
Member

drammock commented Feb 7, 2024

thanks @nabilalibou!

snwnde pushed a commit to snwnde/mne-python that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'custom_ref_applied' is True even if the offline rereferencing is an average

3 participants