Remove incorrect assertions in snirf parsing #12430
Conversation
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
for more information, see https://pre-commit.ci
|
@alexk101 can you add a |
alexk101
requested review from
agramfort,
dengemann,
drammock and
larsoner
as code owners
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
@alexk101 at some point if there is any way you could get a tiny (1s?) recording that shows this problem and add it to mne-testing-data, then we could add a proper regression test that would fail on current main and pass on this PR. But since our current tests pass, I assume you've checked it on your files, and I'm not sure how easy it'll be to get such a file in the testing data, I think we're safe enough to merge here (and should add the additional test in a follow-up PR if we can!).
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
2 participants
Reformats channel and detector lookup from array based to dictionary based. Removes incorrect assertions that every detector and source must have data associated with every registered optode position.
Reference issue
Example: Fixes #12429.
What does this implement/fix?
Reformats channel and detector lookup from array based to dictionary based. Removes incorrect assertions that every detector and source must have data associated with every registered optode position.