Fix stc_near_sensors error #12436
Merged
Fix stc_near_sensors error #12436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrockhill
requested review from
agramfort,
dengemann and
drammock
as code owners
Contributor
Author
|
Failures are unrelated |
Member
|
Yes you shouldn't ever project to surface for a volume stc, the surf argument would be ignored completely in that case |
Contributor
Author
|
Okay to merge to fix the error on |
Member
|
Yes thanks @alexrockhill , feel free to improve the logic in another PR! It's likely volume/surface was not considered when writing this function, I think I wrote it (?) and only ever thought about ECoG projecting to surfaces |
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes broken CI from #12382 (comment)
Ok so, I forgot to test that the shape was the same so volume source estimates with a different rr shape caused an error so I fixed that. But also, in doing so I noticed that the default,
surface='pial'was being used (right). I'm not sure if this was on purpose but I think thesurface=Noneversion looks a lot better (left) which uses the src vertices. I think it actually was super confusing having an STC projected to pial surfaces and I would think maybe is a bug.