Skip to content

don't put pytest marks on test fixtures #12440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsoner merged 1 commit into from
Feb 13, 2024
Merged

don't put pytest marks on test fixtures #12440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions mne/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,8 +797,6 @@ def mixed_fwd_cov_evoked(_evoked_cov_sphere, _all_src_types_fwd):


@pytest.fixture(scope="session")
@pytest.mark.slowtest
@pytest.mark.parametrize(params=[testing._pytest_param()])
def src_volume_labels():
"""Create a 7mm source space with labels."""
pytest.importorskip("nibabel")
Expand Down
1 change: 1 addition & 0 deletions mne/source_space/tests/test_source_space.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -679,6 +679,7 @@ def test_source_space_from_label(tmp_path, pass_ids):
_compare_source_spaces(src, src_from_file, mode="approx")


@pytest.mark.slowtest
@testing.requires_testing_data
def test_source_space_exclusive_complete(src_volume_labels):
Copy link
Member Author

@drammock drammock Feb 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this is the only test function that uses src_volume_labels, and since it's already marked with requires_testing_data I only copied over the slowtest mark.

"""Test that we produce exclusive and complete labels."""
Expand Down