ENH: Add image_kwargs to report.add_epochs #12443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SophieHerbst
requested review from
dengemann,
hoechenberger and
jasmainak
as code owners
for more information, see https://pre-commit.ci
…python into report_add_image_kwargs cannot push without merging upstream
SophieHerbst
requested review from
agramfort,
drammock and
larsoner
as code owners
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
…-python into report_add_image_kwargs asked to merge upstream before pushing
Member
|
@SophieHerbst Almost there, I believe … But linting fails: mne/report/report.py:1126:89: E501 Line too long (112 > 88)
Found 1 error. |
for more information, see https://pre-commit.ci
hoechenberger
approved these changes
Feb 14, 2024
Member
hoechenberger
left a comment
hoechenberger
left a comment
There was a problem hiding this comment.
LGTM
@larsoner There's no tests so far, maybe we should add one…
Contributor
Author
|
@hoechenberger I don't understand what I have to do about the failed tests. |
Member
|
Ah. We need to set image_kwargs to an empty dictionary if it's None. Otherwise the **image_kwargs part doesn't work |
Member
|
@SophieHerbst What I mean is doing something like: if image_kwargs is None:
image_kwargs = dict():) |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
hoechenberger
approved these changes
Feb 15, 2024
Member
|
@larsoner Could you take over here please? I'll be busy until the end of the week |
larsoner
approved these changes
Feb 16, 2024
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Added a tiny test, marking for merge-when-green, thanks @SophieHerbst !
larsoner
changed the title
Member
|
Last CircleCI run worked, no idea why this one didn't but I think we can merge! |
larsoner
added a commit
to SophieHerbst/mne-python
that referenced
this pull request
Feb 20, 2024
* upstream/main: [pre-commit.ci] pre-commit autoupdate (mne-tools#12453) MAINT: Fix CIs for PyQt6 (mne-tools#12452) DOC: add missing info to interpolate bads docstring (mne-tools#12448) FIX: na_rep for reports (mne-tools#12447) ENH: Multiple raw instance support to head pos average (mne-tools#12445) ENH: Add image_kwargs to report.add_epochs (mne-tools#12443)
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com> Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Needed to address
mne-tools/mne-bids-pipeline#848
What does this implement/fix?
Allow to pass image parameters when plotting epochs_images in report.add_epochs: vmin and vmax to control the color scale across participants.
@hoechenberger can you have a look?