ENH: Support partial pathlength factors for each wavelength in Beer-Lambert law #12446
Conversation
scholzri
requested review from
agramfort,
dengemann,
drammock,
larsoner and
rob-luke
as code owners
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
| ---------- | ||
| raw : instance of Raw | ||
| The optical density data. | ||
| ppf : float |
There was a problem hiding this comment.
Hi @agramfort , thank you for the hint, but I do not understand. Which type do you mean? Sorry, I am new to mne and python.
There was a problem hiding this comment.
ppf is not a float anymore here. You make it a list and actually it should be a tuple
There was a problem hiding this comment.
I see. Thank you for the explanation! I changed it.
I also modified the test for beer lambert law.
Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org>
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
We should keep backward compatibility with float, too, which is easy enough to do I think -- see suggested edits!
This reverts commit cc5fe31.
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
|
Thank you for the input @larsoner |
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Looks good other than one thing I think we need to revert. I'll commit the change to get CIs working on everything but let me know if you think it should be 6.0 in the example!
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
|
Thanks @scholzri ! |
…ambert law (mne-tools#12446) Co-authored-by: Alexandre Gramfort <alexandre.gramfort@m4x.org> Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
3 participants
This pull request modifies the beer_lambert_law function to support partial pathlength factors per wavelength, as requested here by myself. The ppf's are now specified in a tuple and converted to a 2x1 array which than can be used in the equation.