Disable interpolation in BrainVision config parser #12456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrnr
requested review from
adam2392,
agramfort,
dengemann,
drammock,
larsoner and
sappelhoff
as code owners
cbrnr
force-pushed
the
brainvision-read-vhdr
branch
from
fbe2201 to
64de235
Compare
Member
|
Didn't even know interpolation was a thing in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently came across a BrainVision file, which contains a channel
SpO2(peripheral oxygen saturation) with a unit%. However, reading this file raises aconfigparser.InterpolationError, because by defaultconfigparser.ConfigParserusesinterpolation=configparser.BasicInterpolation(see here). This means that it uses percent-based interpolation, e.g. it replaces%(some_dir)with the value of the variablesome_dir(defined elsewhere in the config file).I am pretty sure that BrainVision header files do not contain such format strings, and therefore, I suggest that we disable interpolation when parsing this file. That way, channels can be specified to have a unit
%.