Skip to content

FIX: Gracefully handle missing datetime in Eyelink File #12687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larsoner merged 7 commits into from
Jun 28, 2024
Merged

FIX: Gracefully handle missing datetime in Eyelink File #12687

larsoner merged 7 commits into from
Jun 28, 2024

Conversation

@scott-huberty
Copy link
Contributor

@scott-huberty scott-huberty commented Jun 27, 2024

👋

Fixes #12621

@scott-huberty scott-huberty changed the title FIX: Gracefully handle no datetime in Eyelink File FIX: Gracefully handle missing datetime in Eyelink File Jun 27, 2024
larsoner
larsoner reviewed Jun 27, 2024
View reviewed changes
scott-huberty and others added 2 commits June 27, 2024 10:41
@scott-huberty @larsoner
Apply suggestions from code review [ci skip]
035245e 
Skipping CI so I can fix linter errors in a follow up commit before running tests

Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f2241f6 
for more information, see https://pre-commit.ci
@scott-huberty
Copy link
Contributor Author

scott-huberty commented Jun 27, 2024 •
edited
Loading

FYI [ci skip]` Doesn't actually skip the style, azure, and CircleCI checks? I expected that it would. EDIT: a few of the GH actions checks still ran as well.

EDIT: ahhh. I see. The pre-commit bot still ran after my commit, generating another commit and thus running the full CI.... Funny, I used [ci skip] because I knew there would be linter errors and wanted to suppress the CI's, but alas 🙂

@scott-huberty
FIX: lint
bfb7bd4
@scott-huberty
Merge remote-tracking branch 'origin/eyelink_no_date' into eyelink_no…
b419845 
…_date

had to fix conflicts bc I fixed flakes locally while at the same time the precommit bot fixed some flakes directly on the remote...
@scott-huberty
Copy link
Contributor Author

scott-huberty commented Jun 27, 2024 •
edited
Loading

FYI Windows 3.10 pip CI timed out on Azure.

https://dev.azure.com/mne-tools/mne-python/_build/results?buildId=30506&view=ms.vss-test-web.build-test-results-tab

@larsoner larsoner merged commit f16ebc5 into mne-tools:main Jun 28, 2024
@larsoner
Copy link
Member

larsoner commented Jun 28, 2024

Thanks @scott-huberty !

@scott-huberty scott-huberty deleted the eyelink_no_date branch June 28, 2024 14:33
larsoner added a commit to scott-huberty/mne-python that referenced this pull request Jul 16, 2024
@larsoner
Merge remote-tracking branch 'upstream/main' into egi_annots_from_stim
b2e21aa 
* upstream/main: (252 commits)
  Disable the "Back to top" button in the documentation (mne-tools#12688)
  DOC: match_channel_orders works on Epochs and Evoked, too (mne-tools#12699)
  Scale points and labels in montage plot (mne-tools#12703)
  Add license header to mne.stats.erp (mne-tools#12712)
  Update license year to 2024 (mne-tools#12713)
  Add standardized measurement error (SME) (mne-tools#12707)
  ENH: Parallel example execution in doc build (mne-tools#12708)
  MAINT: Update PR template (mne-tools#12692)
  MAINT: Fix doc build (mne-tools#12706)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12702)
  Improve documentation of ylim argument through Evoked plotting function (mne-tools#12697)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12696)
  BUG: Fix bug with CSP rank="full" (mne-tools#12694)
  MRG: Add epochs metadata summary to HTML representation (mne-tools#12686)
  Correct `Epochs.apply_function` docstring (mne-tools#12691)
  FIX: Gracefully handle missing datetime in Eyelink File (mne-tools#12687)
  MAINT: Restore SciPy pre (mne-tools#12689)
  Enh single channel annotation (mne-tools#12669)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#12682)
  Bump autofix-ci/action from 1.2 to 1.3 in the actions group (mne-tools#12681)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner larsoner left review comments

@drammock drammock Awaiting requested review from drammock drammock is a code owner

@agramfort agramfort Awaiting requested review from agramfort agramfort is a code owner

@dengemann dengemann Awaiting requested review from dengemann dengemann is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Eyelink: Accept blank recording dates?

2 participants

@scott-huberty @larsoner