add encoding parameter to read_raw_nirx #12730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
approved these changes
Jul 19, 2024
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
I think we can live without a test if you've tested locally @drammock. In theory you could do some gymnastics with monkeypatch or trying to edit a file's ASCII or binary in the right place (you could figure it out with a fid.tell() maybe then know precisely what to change?) but it seems like more work than it's worth here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new param
encodingtoread_raw_nirx. DefaultNone"latin-1"should be backward compatible. Also adds another strptime pattern (zh-locale appropriate) to check the meas_date against when reading the file.Fixes mne-tools/mne-nirs#543
Draft PR because I haven't added a test yet, and because IDK how many of our readers might need such functionality. Input welcome on that question.